Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics for atomic distributed transactions #16939

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Oct 11, 2024

Description

This PR adds metrics to distributed transaction comit flow for tracking timings and failures.

New Metrics:

  • VTGate

    • CommitModeTimings - Timing metrics for commit (Single, Multi, TwoPC)
    • CommitUnresolved - Counter for failure after Prepare
  • VTTablet

    • UnresolvedTransaction - Gauge to track current unresolved transactions in Metadata and Resource Manager.
    • CommitPreparedFail - Transactions that failed to commit after prepare (classified into Retryable and Non-Retryable)
    • RedoPreparedFail - Transactions that failed to re-prepare (classified into Retryable and Non-Retryable)

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Oct 11, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 11, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 11, 2024
@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving and removed NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (4e89152) to head (dfa8aac).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/dt_executor.go 73.33% 4 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go 66.66% 4 Missing ⚠️
go/vt/vttablet/tabletserver/production.go 0.00% 2 Missing ⚠️
go/vt/vttablet/tabletserver/tx_engine.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16939      +/-   ##
==========================================
- Coverage   69.35%   69.34%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      204149   204214      +65     
==========================================
+ Hits       141583   141613      +30     
- Misses      62566    62601      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Oct 14, 2024
Signed-off-by: Harshit Gangal <[email protected]>
logStats *tabletenv.LogStats
te *TxEngine
qe *QueryEngine
shardFunc func() string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding a comment about what this is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add on a follow up PR.

@harshit-gangal harshit-gangal merged commit d651a42 into vitessio:main Oct 21, 2024
98 checks passed
@harshit-gangal harshit-gangal deleted the metrics-2pc branch October 21, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants