-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metrics for atomic distributed transactions #16939
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16939 +/- ##
==========================================
- Coverage 69.35% 69.34% -0.01%
==========================================
Files 1571 1571
Lines 204149 204214 +65
==========================================
+ Hits 141583 141613 +30
- Misses 62566 62601 +35 ☔ View full report in Codecov by Sentry. |
424d767
to
bb63869
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
bb63869
to
4d877f9
Compare
Signed-off-by: Harshit Gangal <[email protected]>
…ransactions Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
logStats *tabletenv.LogStats | ||
te *TxEngine | ||
qe *QueryEngine | ||
shardFunc func() string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind adding a comment about what this is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add on a follow up PR.
Description
This PR adds metrics to distributed transaction comit flow for tracking timings and failures.
New Metrics:
VTGate
CommitModeTimings
- Timing metrics for commit (Single, Multi, TwoPC)CommitUnresolved
- Counter for failure after PrepareVTTablet
UnresolvedTransaction
- Gauge to track current unresolved transactions in Metadata and Resource Manager.CommitPreparedFail
- Transactions that failed to commit after prepare (classified into Retryable and Non-Retryable)RedoPreparedFail
- Transactions that failed to re-prepare (classified into Retryable and Non-Retryable)Related Issue(s)
Checklist
Deployment Notes