-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent lookup vindex tests for atomic distributed transactions #17393
Merged
GuptaManan100
merged 6 commits into
vitessio:main
from
planetscale:consistent-lookup-vindex-2pc
Dec 18, 2024
Merged
Consistent lookup vindex tests for atomic distributed transactions #17393
GuptaManan100
merged 6 commits into
vitessio:main
from
planetscale:consistent-lookup-vindex-2pc
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…index-2pc Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
Type: Testing
labels
Dec 15, 2024
GuptaManan100
requested review from
harshit-gangal,
systay and
frouioui
as code owners
December 15, 2024 15:48
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 15, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 15, 2024
26 tasks
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17393 +/- ##
=======================================
Coverage 67.52% 67.53%
=======================================
Files 1581 1581
Lines 253948 253945 -3
=======================================
+ Hits 171480 171491 +11
+ Misses 82468 82454 -14 ☔ View full report in Codecov by Sentry. |
systay
reviewed
Dec 17, 2024
systay
approved these changes
Dec 17, 2024
systay
approved these changes
Dec 17, 2024
harshit-gangal
approved these changes
Dec 17, 2024
Signed-off-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds testing for using consistent lookup vindexes for atomic distributed transactions. It also makes the code changes to make them work, which were initially disallowed. The changes are quite self-explanatory. We do the pre-session and post-session changes like we were doing for the normal commit flow, and hence have been moved out into common code path.
Related Issue(s)
Checklist
Deployment Notes