Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vtctldclient missing cmds and remove remaining vtctl[client] usage in e2e tests #17442

Merged
merged 38 commits into from
Jan 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
b2c696d
Add missing TopoCp replacement
mattlord Dec 26, 2024
45dd233
Add CopySchemaShard
mattlord Dec 26, 2024
0e3a8e1
Add ValidateSchemaShard
mattlord Dec 27, 2024
851ccac
Add missing permissions commands
mattlord Dec 27, 2024
05c4c1d
Fixups
mattlord Dec 27, 2024
a091042
Remove CopySchemaShard
mattlord Dec 28, 2024
2ef4690
Revert "Remove CopySchemaShard"
mattlord Dec 31, 2024
f5fcd6c
Start work on CopySchemaShard
mattlord Dec 31, 2024
84d5bdd
Testing and fixing
mattlord Jan 1, 2025
6d8ef71
Topology cmd option cleanup
mattlord Jan 1, 2025
f6da213
Correct vtctldclient --help output
mattlord Jan 1, 2025
02f93a2
Align old and new client resp handling
mattlord Jan 1, 2025
065fd01
Remove unneded call
mattlord Jan 1, 2025
f0047fa
Minor changes from self review
mattlord Jan 1, 2025
24fdf41
Changes from further testing
mattlord Jan 2, 2025
64b9576
Merge remote-tracking branch 'origin/main' into vtctldclient_missing_…
mattlord Jan 2, 2025
f75ed39
Remove and replace all remaining vtctl[client] usage
mattlord Jan 2, 2025
d817b3c
Fix cell bootstrapping
mattlord Jan 2, 2025
efdefd7
Replace remaining usage of VtctlProcess
mattlord Jan 2, 2025
4ec0dc1
Fix vtctldclient creation
mattlord Jan 2, 2025
49e70b1
Fix SecureTransport test
mattlord Jan 2, 2025
6e4a4b0
Fix tabletmanager tests
mattlord Jan 2, 2025
ca1064b
Remove "--" args
mattlord Jan 2, 2025
7b213c3
Update --help output
mattlord Jan 2, 2025
0d136d4
Fix migrate tests
mattlord Jan 2, 2025
8d8b3b4
Fix unit test
mattlord Jan 2, 2025
1cb43c5
Fix vtgate/reference test
mattlord Jan 3, 2025
8f66a9f
Fix ERS test
mattlord Jan 3, 2025
e1832b2
Fix backup tests
mattlord Jan 3, 2025
e89ca17
Changes from self review
mattlord Jan 3, 2025
2de0bcf
Merge remote-tracking branch 'origin/main' into vtctldclient_missing_…
mattlord Jan 11, 2025
2e4cd37
Update vtctldclient help text
mattlord Jan 16, 2025
096b292
Merge remote-tracking branch 'origin/main' into vtctldclient_missing_…
mattlord Jan 16, 2025
60fca3a
Add unit tests for permissions commands
mattlord Jan 17, 2025
1073206
Reorgnaize the permissions tests
mattlord Jan 17, 2025
afbeb6b
Update copyright year on new files
mattlord Jan 17, 2025
78ca3e0
Fix TestRootWithInternalVtctld
mattlord Jan 17, 2025
5441073
Merge remote-tracking branch 'origin/main' into vtctldclient_missing_…
mattlord Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor changes from self review
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord committed Jan 1, 2025
commit f0047fa3c9f0f4d2fab7c2903102bb3b09b76593
3 changes: 3 additions & 0 deletions go/vt/vtctl/grpcvtctldserver/server.go
Original file line number Diff line number Diff line change
@@ -882,6 +882,9 @@ func (s *VtctldServer) CopySchemaShard(ctx context.Context, req *vtctldatapb.Cop
span.Annotate("destination_shard", req.DestinationShard)

waitReplicasTimeout, _, err := protoutil.DurationFromProto(req.WaitReplicasTimeout)
if err != nil {
return nil, err
}

return &vtctldatapb.CopySchemaShardResponse{}, s.ws.CopySchemaShard(ctx,
req.SourceTabletAlias, req.Tables, req.ExcludeTables, req.IncludeViews, req.DestinationKeyspace, req.DestinationShard,