Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vexplain to protect the log fields from concurrent writes #17460

Merged
merged 1 commit into from
Jan 6, 2025
Merged

vexplain to protect the log fields from concurrent writes #17460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions go/vt/vtgate/executorcontext/vcursor_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"io"
"sort"
"strings"
"sync"
"sync/atomic"
"time"

Expand Down Expand Up @@ -154,6 +155,8 @@ type (

observer ResultsObserver

// this protects the interOpStats and shardsStats fields from concurrent writes
mu sync.Mutex
// this is a map of the number of rows that every primitive has returned
// if this field is nil, it means that we are not logging operator traffic
interOpStats map[engine.Primitive]engine.RowsReceived
Expand Down Expand Up @@ -642,21 +645,29 @@ func (vc *VCursorImpl) ExecutePrimitive(ctx context.Context, primitive engine.Pr
}

func (vc *VCursorImpl) logOpTraffic(primitive engine.Primitive, res *sqltypes.Result) {
if vc.interOpStats != nil {
rows := vc.interOpStats[primitive]
if res == nil {
rows = append(rows, 0)
} else {
rows = append(rows, len(res.Rows))
}
vc.interOpStats[primitive] = rows
if vc.interOpStats == nil {
return
}

vc.mu.Lock()
defer vc.mu.Unlock()

rows := vc.interOpStats[primitive]
if res == nil {
rows = append(rows, 0)
} else {
rows = append(rows, len(res.Rows))
}
vc.interOpStats[primitive] = rows
}

func (vc *VCursorImpl) logShardsQueried(primitive engine.Primitive, shardsNb int) {
if vc.shardsStats != nil {
vc.shardsStats[primitive] += engine.ShardsQueried(shardsNb)
if vc.shardsStats == nil {
return
}
vc.mu.Lock()
defer vc.mu.Unlock()
vc.shardsStats[primitive] += engine.ShardsQueried(shardsNb)
}

func (vc *VCursorImpl) ExecutePrimitiveStandalone(ctx context.Context, primitive engine.Primitive, bindVars map[string]*querypb.BindVariable, wantfields bool) (*sqltypes.Result, error) {
Expand Down
Loading