-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move VDiff related workflow server APIs to vdiff.go
and add unit tests
#17466
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17466 +/- ##
=======================================
Coverage 67.67% 67.67%
=======================================
Files 1583 1584 +1
Lines 254363 254368 +5
=======================================
+ Hits 172140 172149 +9
+ Misses 82223 82219 -4 ☔ View full report in Codecov by Sentry. |
// // VDiffCreate is part of the vtctlservicepb.VtctldServer interface. | ||
// // It passes on the request to the target primary tablets that are | ||
// // participating in the given workflow and VDiff. | ||
// func (s *Server) VDiffCreate(ctx context.Context, req *vtctldatapb.VDiffCreateRequest) (*vtctldatapb.VDiffCreateResponse, error) { | ||
// span, ctx := trace.NewSpan(ctx, "workflow.Server.VDiffCreate") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to remove all of this commented code that was removed, don't we?
Description
This PR
Server
APIs fromserver.go
tovdiff.go
vdiff_test.go
VDiffDelete
The change in code coverage:
Code coverage on main:
Code coverage on vdiff-refactor:
Related Issue(s)
Checklist
Deployment Notes