Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StalledDiskPrimary analysis and recovery to vtorc #17470

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+378 −29

feat: add summary notes for the changes

df939e8
Select commit
Loading
Failed to load commit list.
Open

Add StalledDiskPrimary analysis and recovery to vtorc #17470

feat: add summary notes for the changes
df939e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 7, 2025 in 0s

67.65% (-0.02%) compared to 8ba7607

View this Pull Request on Codecov

67.65% (-0.02%) compared to 8ba7607

Details

Codecov Report

Attention: Patch coverage is 71.15385% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.65%. Comparing base (8ba7607) to head (df939e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...o/vt/vttablet/tabletmanager/disk_health_monitor.go 76.05% 17 Missing ⚠️
go/vt/vtorc/inst/instance_dao.go 54.54% 5 Missing ⚠️
go/vt/vtorc/config/config.go 0.00% 4 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 3 Missing ⚠️
go/vt/vtorc/logic/topology_recovery.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17470      +/-   ##
==========================================
- Coverage   67.67%   67.65%   -0.02%     
==========================================
  Files        1584     1585       +1     
  Lines      254368   254466      +98     
==========================================
+ Hits       172139   172161      +22     
- Misses      82229    82305      +76

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov