-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in the evalengine #17487
Merged
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-evalengine-crash
Jan 8, 2025
Merged
Fix crash in the evalengine #17487
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-evalengine-crash
Jan 8, 2025
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Bug
Component: Query Serving
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
labels
Jan 8, 2025
dbussink
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
January 8, 2025 14:17
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 8, 2025
vmg
approved these changes
Jan 8, 2025
The allocation arena used here the wrong type to check for the size. The logic here was copied, but this case was missed. We add a test here and fix the bug. It applies to both enums and sets. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
dbussink/fix-evalengine-crash
branch
from
January 8, 2025 14:18
ef4b86b
to
a001ff3
Compare
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 8, 2025
GuptaManan100
approved these changes
Jan 8, 2025
vitess-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Dirkjan Bussink <[email protected]>
vitess-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
dbussink
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocation arena used here the wrong type to check for the size. The logic here was copied, but this case was missed.
We add a test here and fix the bug. It applies to both enums and sets.
Should be backported to all supported versions as this can lead to a panic.
Related Issue(s)
Fixes #17486
Checklist