-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing MySQL 8.4 keywords #17538
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Leopold Jacquot <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17538 +/- ##
==========================================
+ Coverage 67.68% 67.71% +0.02%
==========================================
Files 1584 1584
Lines 254630 254717 +87
==========================================
+ Hits 172356 172472 +116
+ Misses 82274 82245 -29 ☔ View full report in Codecov by Sentry. |
@@ -1,5 +1,5 @@ | |||
// Code generated by `SELECT * FROM INFORMATION_SCHEMA.KEYWORDS`. | |||
// Reference: https://dev.mysql.com/doc/refman/8.0/en/information-schema-keywords-table.html | |||
// Reference: https://dev.mysql.com/doc/refman/8.4/en/information-schema-keywords-table.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably makes sense to use the MySQL 9.0 output. It's almost identical, except for the fact that it also has Vector. AKA, it's exactly what we're aiming to support at the moment.
@@ -67,16 +67,16 @@ public class VitessMySQLDatabaseMetadata extends VitessDatabaseMetaData implemen | |||
"INNER", "INOUT", "INSENSITIVE", "INSERT", "INT", "INT1", "INT2", "INT3", "INT4", "INT8", | |||
"INTEGER", "INTERVAL", "INTO", "IS", "ITERATE", "JOIN", "KEY", "KEYS", "KILL", "LEADING", | |||
"LEAVE", "LEFT", "LIKE", "LIMIT", "LINEAR", "LINES", "LOAD", "LOCALTIME", "LOCALTIMESTAMP", | |||
"LOCK", "LONG", "LONGBLOB", "LONGTEXT", "LOOP", "LOW_PRIORITY", "MATCH", "MEDIUMBLOB", | |||
"LOCK", "LONG", "LONGBLOB", "LONGTEXT", "LOOP", "LOW_PRIORITY", "MANUAL", "MATCH", "MEDIUMBLOB", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole list needs re-formatting, for the CI to pass. line wrapping at 100 chars required.
Takes #17525 and adds the fix for the change here as requested by @L3o-pold.
Related Issue(s)
Fixes #17523
Checklist