-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always return a valid timezone in cursor #17546
Merged
Merged
+19
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conversion functions into a Go `time.Time` expect to have a valid `*time.Location` and will panic if passed in `nil`. Before we used also here `nil` to signal no timezone is set (and thus falling back to `time.Local` implicitly, but it's better to always return a timezone explicitly and use `time.Local` where appropriate then. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
added
Type: Bug
Component: Query Serving
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
labels
Jan 15, 2025
dbussink
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
January 15, 2025 19:39
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 15, 2025
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 15, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17546 +/- ##
==========================================
+ Coverage 67.68% 67.70% +0.01%
==========================================
Files 1584 1584
Lines 254717 254718 +1
==========================================
+ Hits 172417 172465 +48
+ Misses 82300 82253 -47 ☔ View full report in Codecov by Sentry. |
frouioui
approved these changes
Jan 15, 2025
GuptaManan100
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
rohit-nayak-ps
pushed a commit
that referenced
this pull request
Jan 16, 2025
) Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
rohit-nayak-ps
pushed a commit
that referenced
this pull request
Jan 16, 2025
) Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion functions into a Go
time.Time
expect to have a valid*time.Location
and will panic if passed innil
.Before we used also here
nil
to signal no timezone is set (and thus falling back totime.Local
implicitly, but it's better to always return a timezone explicitly and usetime.Local
where appropriate then.Related Issue(s)
Fixes #17545
Marked also for back porting as this can panic.
Checklist