-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication Workflow command: Allow stop/start on specific shards #17581
Merged
rohit-nayak-ps
merged 2 commits into
vitessio:main
from
planetscale:rohit/stop-start-shards
Jan 22, 2025
Merged
VReplication Workflow command: Allow stop/start on specific shards #17581
rohit-nayak-ps
merged 2 commits into
vitessio:main
from
planetscale:rohit/stop-start-shards
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: VReplication
labels
Jan 20, 2025
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 20, 2025
rohit-nayak-ps
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Jan 20, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17581 +/- ##
==========================================
- Coverage 67.69% 67.68% -0.01%
==========================================
Files 1586 1586
Lines 255403 255409 +6
==========================================
- Hits 172883 172875 -8
- Misses 82520 82534 +14 ☔ View full report in Codecov by Sentry. |
rohit-nayak-ps
requested review from
deepthi,
harshit-gangal and
mattlord
as code owners
January 20, 2025 22:31
rohit-nayak-ps
requested review from
shlomi-noach
and removed request for
harshit-gangal
January 20, 2025 23:15
mattlord
approved these changes
Jan 21, 2025
deepthi
approved these changes
Jan 22, 2025
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
force-pushed
the
rohit/stop-start-shards
branch
from
January 22, 2025 18:22
f3e1f5a
to
3b83410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While importing from massive external databases into a sharded Vitess cluster with multiple shards, the initial load from multiple copy phases is significant. Right now we don't have the ability to stop or start a workflow on a subset of shards. Allowing this feature will allow us to
auto-start=false
This PR adds the ability to stop/start shards by passing the
--shards
flag.Note
We were already accepting
--shards
but it was being ignored.Related issues
Checklist
Deployment Notes