Skip to content

Commit

Permalink
fix loadUsers default value (#1869)
Browse files Browse the repository at this point in the history
* fix loadUsers default value

Signed-off-by: Renan Rangel <[email protected]>

* fix loadUsers default value in v22 too

Signed-off-by: Renan Rangel <[email protected]>

---------

Signed-off-by: Renan Rangel <[email protected]>
  • Loading branch information
rvrangel authored Oct 16, 2024
1 parent 93ba0eb commit 7781d4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ __Optional flags:__
* `progressFile` must be empty indicate we are starting a new backup and not continuing an
existing one
* `skipBinlog` must be `true` so we are not logging the statements to binary logs during the restore
* `loadUsers` defaults to `true`, but it is not required. This is ideal if you rely on Vitess
* `loadUsers` defaults to `false`, but it is not required. This is ideal if you rely on Vitess
managing credentials as we will delete users by default during the dump process. If you perform
your own credential management you might want to disable this.
* these are all defaults in Vitess, but if you define this flag it must include the values above. other options can be found in the [MySQL docs](https://dev.mysql.com/doc/mysql-shell/8.0/en/mysql-shell-utilities-load-dump.html)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ __Optional flags:__
* `progressFile` must be empty indicate we are starting a new backup and not continuing an
existing one
* `skipBinlog` must be `true` so we are not logging the statements to binary logs during the restore
* `loadUsers` defaults to `true`, but it is not required. This is ideal if you rely on Vitess
* `loadUsers` defaults to `false`, but it is not required. This is ideal if you rely on Vitess
managing credentials as we will delete users by default during the dump process. If you perform
your own credential management you might want to disable this.
* these are all defaults in Vitess, but if you define this flag it must include the values above. other options can be found in the [MySQL docs](https://dev.mysql.com/doc/mysql-shell/8.0/en/mysql-shell-utilities-load-dump.html)
Expand Down

0 comments on commit 7781d4c

Please sign in to comment.