-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(browser): support clipboard api userEvent.copy, cut, paste
#6769
Open
hi-ogawa
wants to merge
13
commits into
vitest-dev:main
Choose a base branch
from
hi-ogawa:feat-browser-clipboard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+182
−4
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c6ea761
test: add test
hi-ogawa 30c458f
test: debug
hi-ogawa 1d477ab
test: meta only for playwright/darwin
hi-ogawa a298b25
test: fix webdriverio
hi-ogawa ab76c71
fix: fix webdriverio special key
hi-ogawa 212dac1
test: tweak
hi-ogawa 9506828
feat: implement copy, cut, paste
hi-ogawa cb717ab
fix: fix on preview
hi-ogawa 7da03e8
docs: jsdoc
hi-ogawa d4620bd
chore: cleanup
hi-ogawa 24fd7dd
test: double click to select text
hi-ogawa 390457f
docs: more
hi-ogawa f6cfc27
test: tweak
hi-ogawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { expect, test } from 'vitest'; | ||
import { page, userEvent } from '@vitest/browser/context'; | ||
|
||
test('clipboard', async () => { | ||
// make it smaller since webdriverio fails when scaled | ||
page.viewport(300, 300) | ||
|
||
document.body.innerHTML = ` | ||
<input placeholder="first" /> | ||
<input placeholder="second" /> | ||
<input placeholder="third" /> | ||
`; | ||
|
||
// write first "hello" and copy to clipboard | ||
await userEvent.click(page.getByPlaceholder('first')); | ||
await userEvent.keyboard('hello'); | ||
await userEvent.dblClick(page.getByPlaceholder('first')); | ||
await userEvent.copy(); | ||
|
||
// paste into second | ||
await userEvent.click(page.getByPlaceholder('second')); | ||
await userEvent.paste(); | ||
|
||
// append first "world" and cut | ||
await userEvent.click(page.getByPlaceholder('first')); | ||
await userEvent.keyboard('world'); | ||
await userEvent.dblClick(page.getByPlaceholder('first')); | ||
await userEvent.cut(); | ||
|
||
// paste it to third | ||
await userEvent.click(page.getByPlaceholder('third')); | ||
await userEvent.paste(); | ||
|
||
expect([ | ||
(page.getByPlaceholder('first').element() as any).value, | ||
(page.getByPlaceholder('second').element() as any).value, | ||
(page.getByPlaceholder('third').element() as any).value, | ||
]).toMatchInlineSnapshot(` | ||
[ | ||
"", | ||
"hello", | ||
"helloworld", | ||
] | ||
`) | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this as it wasn't working when
key === 'Ctrl'
, which is webdriverio's special key to switch modifier keys based on platform. I'm not sure the original code's intent, but it didn't break existing tests.