Video Decoder using external ffmpeg process #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faberf
reviewed
Oct 25, 2024
ppanopticon
requested changes
Nov 4, 2024
There was a problem hiding this comment.
I think there is still some work to do here.
Let me know @lucaro if you need support with this. I can try to come-up with some of the changes.
vitrivr-engine-index/src/main/kotlin/org/vitrivr/engine/index/decode/FFmpegVideoDecoder.kt
Outdated
Show resolved
Hide resolved
vitrivr-engine-index/src/main/kotlin/org/vitrivr/engine/index/decode/FFmpegVideoDecoder.kt
Outdated
Show resolved
Hide resolved
vitrivr-engine-index/src/main/kotlin/org/vitrivr/engine/index/decode/FFmpegVideoDecoder.kt
Outdated
Show resolved
Hide resolved
added 5 commits
November 5, 2024 18:22
…has been finalised.
…types (e.g., thumbnail and audio clip).
lucaro
commented
Nov 8, 2024
vitrivr-engine-index/src/main/kotlin/org/vitrivr/engine/index/decode/FFmpegVideoDecoder.kt
Outdated
Show resolved
Hide resolved
ppanopticon
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a video
Decoderbased on Jaffree that uses an external ffmpeg process. Since the ffmpeg process is started anew for eachSource, this can prevent problems such as the accumulation of memory during longer extractions. The current implementation only supports video decoding, audio streams are currently ignored.