refactor: HtmlSerializer for TextBone
#631
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested state.
phorward
added
Priority: Low
phorward
changed the title
phorward
changed the title
phorward
changed the title
HtmlSerializer for TextBone
phorward
added a commit
that referenced
this pull request
Oct 9, 2024
Provide the HtmlBone (TextBone) "validHtml"-default as a config variable, so it can be changed globally. This feature is useful to some projects, and is a first improvement on the messy TextBone class. Relates to and partly replaces #631. --------- Co-authored-by: Sven Eberth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work-in-progress - NO review required for now!
I've started this during #514, where I found that TextBones that are emptied still store a HTML
<p></p><br>which should be considered as an empty-value as well. Why is there also an empty<p></p>? All this brought me to the definition of this dict with the valid HTML, which is just terrible.Therefore, this PR should clean-up the HtmlSerializer-part of TextBone and should also maybe make the definition of custom whitelist settings easier, as it is currently the case.