Make Process.default_state recursive #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eagmon
reviewed
Aug 2, 2023
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## v1.5.6 | |||
eagmon
approved these changes
Aug 2, 2023
|
Ready to merge. I'm pretty sure the required statuses thing is something that was configured on GitHub itself under Settings > Branches > Edit master > Require status checks to pass before merging. I can see it for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though it is rarely used, the
Process.default_statemethod previously broke when a process' ports schema had ports that were either not nested at all or nested more than one level deep. This PR fixes that by makingdefault_staterecursive and adds a test to ensure it works.By creating this pull request, I agree to the Contributor License
Agreement, which is available in
CLA.mdat the top level of thisrepository.