Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIVO-4000 Fixes for search result export to CSV #4004

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

litvinovg
Copy link
Collaborator

@litvinovg litvinovg commented Sep 9, 2024

VIVO GitHub issue

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)
    Related Vitro PR

What does this pull request do?

Removes leading lines from template to export search results in csv format.

How should this be tested?

  • Go to search page
  • Export search results to CSV
  • Verify that there are no longer not csv formatted lines at the beginning on the file
  • Verify that filename contains date time and site name.

Interested parties

@VIVO-project/vivo-committers @hauschke

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. FreeMarker

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

@chenejac chenejac merged commit 04a0e75 into vivo-project:main Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove useless first two lines from search results as CSV
2 participants