Moving Data Distribution API into the Vitro codebase #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takeover from graham rm unimplemented or unnecessary classes rm unused distributors added us text for vqt use local server port to make new request instead of port used by the client fix self signed certificate issue Renamed german translation properties checkstyle fixes
This reverts commit 7c2f665991b94c8d9f7e4f38342502815a4be8f7.
This reverts commit 915f96dc8549f11aad44c62a21f5096e02345528.
|
@markuskotte agreed to review German language parts, when and if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Added the Data Distribution API and report generation into Vitro codebase.
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Interested parties
@chenejac @hauschke @brianjlowe
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
Please update the following template which should be used by reviewers.
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed