feat| Added support for custom build directory #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanolee
reviewed
Aug 1, 2021
| @@ -17,7 +17,8 @@ module.exports = { | |||
| // }, | |||
| // | |||
| _findFunctionPathAndHandler(functionHandler) { | |||
| const dir = path.dirname(functionHandler); | |||
| const buildDir = this.options.buildDir ? `${this.options.buildDir}/` : ''; | |||
| const dir = `${buildDir}${path.dirname(functionHandler)}`; | |||
There was a problem hiding this comment.
Might be worth making this configurable from the custom: config object also? (Or possibly under something like )
stepFunctions:
build:
path: './webpack/some/path'So it does not have to be entered from the CLI / scripts all the time 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin doesn't work properly with a Typescript project. It uses the wrong path to the function file.
To fix this issue I added an option to specify the build directory.