Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

Commit

Permalink
Vulnerable configs can only be set in user or remote
Browse files Browse the repository at this point in the history
  • Loading branch information
vknabel committed Mar 15, 2021
1 parent b82347f commit fc28a1d
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 7 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

-

## 2.12.1

Fixes vulnerability which allowed malicous workspaces to execute code when opened by providing. Now the vulnerable configs cannot be overrided in workspaces anymore:
`sourcekit-lsp.serverPath`, `swift.languageServerPath`, `swift.path.sourcekite`, `swift.path.sourcekiteDockerMode`, `swift.path.swift_driver_bin`, `swift.path.shell`.


## 2.12.0

- Better and more helpful error messages on first start
Expand Down
20 changes: 13 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"url": "https://github.com/vknabel"
},
"license": "Apache-2.0",
"version": "2.12.0",
"version": "2.12.1",
"publisher": "vknabel",
"icon": "icons/icon.png",
"galleryBanner": {
Expand Down Expand Up @@ -108,7 +108,8 @@
"properties": {
"sourcekit-lsp.serverPath": {
"type": "string",
"description": "The path of the sourcekit-lsp executable\nIn SDE: defaults to the toolchain's sourcekit-lsp."
"description": "The path of the sourcekit-lsp executable\nIn SDE: defaults to the toolchain's sourcekit-lsp. Only available in global config for security reasons.",
"scope": "machine"
},
"sourcekit-lsp.toolchainPath": {
"type": "string",
Expand All @@ -117,26 +118,31 @@
"swift.languageServerPath": {
"type": "string",
"default": "/usr/local/bin/langserver-swift",
"description": "[DEPRECATED] The fully qualified path to the Swift Language Server executable."
"description": "[DEPRECATED] The fully qualified path to the Swift Language Server executable. Only available in global config for security reasons.",
"scope": "machine"
},
"swift.path.sourcekite": {
"type": "string",
"description": "The fully path to the sourcekite(SDE's LS backend)."
"description": "The fully path to the sourcekite(SDE's LS backend). Only available in global config for security reasons.",
"scope": "machine"
},
"swift.path.sourcekiteDockerMode": {
"type": "boolean",
"default": false,
"description": "[DEPRECATED] (Experimental)Enable to run dedicated docker shell command. It is the responsibility of user to guarantee that the docker cmd 'docker run --rm -i jinmingjian/docker-sourcekite' works in your system."
"description": "[DEPRECATED] (Experimental)Enable to run dedicated docker shell command. It is the responsibility of user to guarantee that the docker cmd 'docker run --rm -i jinmingjian/docker-sourcekite' works in your system.",
"scope": "machine"
},
"swift.path.swift_driver_bin": {
"type": "string",
"default": "/usr/bin/swift",
"description": "The fully path to the swift driver binary."
"description": "The fully path to the swift driver binary. Only available in global config for security reasons.",
"scope": "machine"
},
"swift.path.shell": {
"type": "string",
"default": "/bin/sh",
"description": "The fully path to the shell binary."
"description": "The fully path to the shell binary. Only available in global config for security reasons.",
"scope": "machine"
},
"sde.sourcekit.compilerOptions": {
"type": "array",
Expand Down

0 comments on commit fc28a1d

Please sign in to comment.