-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #111 Comment out the Legislative panel #112
Conversation
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Abhinav-Chdhary - thank you for tackling this, but we won't be bringing back the panel (or we'll revert the PR and do something similar) so please remove it completely! |
Completely remove the panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, awesome work @Abhinav-Chdhary! Out of curiosity, how did you hear about this project?
|
||
// TODO: Figure out a way to get metaInfo working without any | ||
// https://github.com/xerebede/gridsome-starter-typescript/issues/37 | ||
@Component<any>({ |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
}) | ||
export default class BiggestBuildings extends Vue { | ||
/** Set by Gridsome to results of GraphQL query */ | ||
$page: any; |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
@vkoves Thanks! |
Description
This pull request is an attempt to fix #111 . For now I have just commented it out, let me know if I should completely remove it.
Fixes #111
Checklist: