Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #111 Comment out the Legislative panel #112

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Abhinav-Chdhary
Copy link
Contributor

Description

This pull request is an attempt to fix #111 . For now I have just commented it out, let me know if I should completely remove it.

Fixes #111

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit c09cefe
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/669f1fdc8ffecf00080f2514
😎 Deploy Preview https://deploy-preview-112--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vkoves
Copy link
Owner

vkoves commented Jul 23, 2024

@Abhinav-Chdhary - thank you for tackling this, but we won't be bringing back the panel (or we'll revert the PR and do something similar) so please remove it completely!

@vkoves vkoves self-assigned this Jul 23, 2024
@vkoves vkoves added the bug Something isn't working label Jul 23, 2024
Completely remove the panel
Copy link
Owner

@vkoves vkoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work @Abhinav-Chdhary! Out of curiosity, how did you hear about this project?


// TODO: Figure out a way to get metaInfo working without any
// https://github.com/xerebede/gridsome-starter-typescript/issues/37
@Component<any>({

Check warning

Code scanning / ESLint

Disallow the `any` type Warning

Unexpected any. Specify a different type.
})
export default class BiggestBuildings extends Vue {
/** Set by Gridsome to results of GraphQL query */
$page: any;

Check warning

Code scanning / ESLint

Disallow the `any` type Warning

Unexpected any. Specify a different type.
@vkoves vkoves merged commit 879f1e4 into vkoves:main Jul 24, 2024
7 checks passed
@Abhinav-Chdhary
Copy link
Contributor Author

Looks great, awesome work @Abhinav-Chdhary! Out of curiosity, how did you hear about this project?

@vkoves Thanks!
I was just hunting for good first issues😅. Is there a project you want to collaborate on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Homepage Legislative Call to Action (Dead Link)
2 participants