Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python Data Tests & Add to CI Via GitHub Actions #80

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Conversation

vkoves
Copy link
Owner

@vkoves vkoves commented Mar 20, 2024

Description

Adds a GitHub action to run the new tests Alex added, ensuring no new PRs can go through that break data processing. See PR #68 for the original PR adding the tests.

Fixes #79

Testing Instructions

Ran tests locally and in CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit 534ab06
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/65fe4d5eaf24fc0008cbc204
😎 Deploy Preview https://deploy-preview-80--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vkoves vkoves added the enhancement New feature or request label Mar 20, 2024
@vkoves
Copy link
Owner Author

vkoves commented Mar 20, 2024

@alexkcode - this PR might interest you, I'm trying to get your tests working on all PRs!

Should we limit this to only run on changes of certain files (related StackOverflow) maybe just .csv and .py changes?

Also specify Python 3.9
@vkoves
Copy link
Owner Author

vkoves commented Mar 20, 2024

Looks like the tests now run but have two failures, we'll have to fix or disable those:

Screenshot from 2024-03-20 09-10-24

@vkoves vkoves changed the title Try new Pytest GitHub action Fix Python Data Tests & Add to CI Via GitHub Actions Mar 23, 2024
@vkoves vkoves marked this pull request as ready for review March 23, 2024 03:32
Copy link
Collaborator

@alexkcode alexkcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ran through the tests and did some quick checks on the website.

@vkoves vkoves merged commit ac2d048 into main Apr 2, 2024
7 checks passed
@vkoves vkoves deleted the test-automation branch April 2, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add New Tests As CI Via GitHub Action
2 participants