Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loyola Building Owner Page & Tag More University Buildings #85

Merged
merged 5 commits into from
Mar 30, 2024

Conversation

vkoves
Copy link
Owner

@vkoves vkoves commented Mar 30, 2024

Description

Adds a Loyola building owner page with 26 tagged buildings, and tags more university buildings we missed:

Screenshot from 2024-03-30 16-43-38

A fun trick was that Loyola seemed to have all their buildings include the string "ID#" with the city ID number added, which helped me track down more buildings that weren't tagged as university buildings (e.g. dorms).

Fixes #82

Testing Instructions

Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

vkoves added 5 commits March 30, 2024 12:12
Used a starting set from Rachel, but then noticed that they
all had a quirk of including 'ID#' in the title, which
found a lot more
@vkoves vkoves added the data Data updates & tweaks label Mar 30, 2024
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit f55c2c3
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/660887d3f55c2700085e3193
😎 Deploy Preview https://deploy-preview-85--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vkoves vkoves marked this pull request as ready for review March 30, 2024 21:53
@vkoves
Copy link
Owner Author

vkoves commented Mar 30, 2024

Since this just tags more buildings, and I checked all of them on Google Maps, I'm going to merge this through personally

@vkoves vkoves merged commit 4ba63e7 into main Mar 30, 2024
6 checks passed
@vkoves vkoves deleted the tag-more-buildings branch March 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Data updates & tweaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Loyola Buildings & Missing Other Buildings
1 participant