Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: implement overriding of != and == #7837

Merged
merged 6 commits into from
Jan 3, 2021
Merged

cgen: implement overriding of != and == #7837

merged 6 commits into from
Jan 3, 2021

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Jan 3, 2021

This PR implements #7742

@Delta456 Delta456 marked this pull request as draft January 3, 2021 12:23
@Delta456 Delta456 marked this pull request as ready for review January 3, 2021 13:20
@esquerbatua
Copy link
Contributor

esquerbatua commented Jan 3, 2021 •
edited
Loading

Great job!!
Can update also the docs?
https://github.com/vlang/v/blob/master/doc/docs.md#limited-operator-overloading

@Delta456
Copy link
Member Author

Delta456 commented Jan 3, 2021

Great job!!
Can update also the docs?
https://github.com/vlang/v/blob/master/doc/docs.md#limited-operator-overloading

It is there.

medvednikov
medvednikov reviewed Jan 3, 2021
View reviewed changes
vlib/v/gen/cgen.v Outdated Show resolved Hide resolved
@medvednikov
Copy link
Member

@Delta456 also for a major change like this, don't forget to update CHANGELOG.md right away.

@medvednikov medvednikov merged commit 9033099 into vlang:master Jan 3, 2021
@Delta456 Delta456 deleted the eq_and_ne_op branch January 4, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medvednikov medvednikov medvednikov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Delta456 @esquerbatua @medvednikov