Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] For ppc64le, disabled tests for now and addressed space issues #10538

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

npanpaliya
Copy link
Contributor

@npanpaliya npanpaliya commented Nov 21, 2024

For ppc64le, vllm tests have been failing due to which the build and test job is failing. For now, we have disabled the tests so that atleast build can be enabled for ppc64le, while we work on the tests failure. This PR also addresses the CI agent disk space issues.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 21, 2024
@sumitd2
Copy link
Contributor

sumitd2 commented Nov 21, 2024

@khluu
@npanpaliya is from my team and she will take care of the Power build and test issues from now on. So please tag her in future when you need to delegate the task to us. I have tested the CI job locally and its passing.

Please also enable the Power CI after you merge this.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 23, 2024
@DarkLight1337 DarkLight1337 self-requested a review November 23, 2024 06:06
@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 23, 2024

Sorry for the delay.

Ping: @khluu in case you missed it.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 23, 2024 06:07
@DarkLight1337 DarkLight1337 changed the title For ppc64le, disabled tests for now and addressed space issues [CI/Build] For ppc64le, disabled tests for now and addressed space issues Nov 23, 2024
@DarkLight1337 DarkLight1337 merged commit 651f6c3 into vllm-project:main Nov 23, 2024
43 of 45 checks passed
@npanpaliya
Copy link
Contributor Author

Thank you @DarkLight1337 for merging this PR.

@sumitd2
Copy link
Contributor

sumitd2 commented Nov 26, 2024

@DarkLight1337 Is the PR check for ppc64le now enabled?

@DarkLight1337
Copy link
Member

@simon-mo can you enable it?

@sumitd2
Copy link
Contributor

sumitd2 commented Nov 28, 2024

@simon-mo can you enable it?

@simon-mo Have we enabled it?

mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
npanpaliya added a commit to npanpaliya/vllm that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants