Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token-adding chat embedding params #10551

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

noamgat
Copy link
Contributor

@noamgat noamgat commented Nov 21, 2024

This follows the discussion in:

#10501 (comment)

Where @DarkLight1337 agreed that its better to remove the parameters altogether.

In embedding, the model does not generate additional tokens on top of the input text. Therefore, all parameters like "should a start-of-assistant-turn token be added" don't make sense, and should be removed.

This replaces that PR with the agreed-upon solution

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Nov 21, 2024
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 22, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 22, 2024 03:27
@noamgat
Copy link
Contributor Author

noamgat commented Nov 22, 2024

Hey, some of the tests fail but it looks unrelated to my changes. How can we proceed with the merge?

@DarkLight1337
Copy link
Member

Asking for force-merge.

@youkaichao youkaichao disabled auto-merge November 22, 2024 07:59
@youkaichao youkaichao merged commit 11fcf0e into vllm-project:main Nov 22, 2024
61 of 63 checks passed
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants