-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove token-adding chat embedding params #10551
Remove token-adding chat embedding params #10551
Conversation
…ingChatRequest Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: Noam Gat <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Hey, some of the tests fail but it looks unrelated to my changes. How can we proceed with the merge? |
Asking for force-merge. |
Signed-off-by: Noam Gat <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Noam Gat <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Noam Gat <[email protected]>
This follows the discussion in:
#10501 (comment)
Where @DarkLight1337 agreed that its better to remove the parameters altogether.
In embedding, the model does not generate additional tokens on top of the input text. Therefore, all parameters like "should a start-of-assistant-turn token be added" don't make sense, and should be removed.
This replaces that PR with the agreed-upon solution