Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platforms] Refactor openvino code #10573

Merged
merged 2 commits into from
Nov 23, 2024
Merged

[Platforms] Refactor openvino code #10573

merged 2 commits into from
Nov 23, 2024

Conversation

ji-huazhong
Copy link
Contributor

@ji-huazhong ji-huazhong commented Nov 22, 2024 •
edited by github-actions bot
Loading

Part of #9268

cc @youkaichao

@ji-huazhong ji-huazhong marked this pull request as draft November 22, 2024 12:04
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ji-huazhong ji-huazhong marked this pull request as ready for review November 22, 2024 12:22
@ji-huazhong ji-huazhong force-pushed the platform branch 4 times, most recently from cd1f704 to a58d795 Compare November 22, 2024 12:43
youkaichao
youkaichao reviewed Nov 22, 2024
View reviewed changes
vllm/platforms/openvino.py Outdated
import torch

import vllm.envs as envs
from vllm.logger import init_logger
from vllm.utils import GiB_bytes
Copy link
Member

@youkaichao youkaichao Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to import it lazily inside the check_and_update_config function

Copy link
Contributor Author

@ji-huazhong ji-huazhong Nov 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 3699c9d

Copy link
Contributor Author

@ji-huazhong ji-huazhong Nov 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @youkaichao

@ji-huazhong
import GiB_bytes lazily
3699c9d 
Signed-off-by: statelesshz <[email protected]>
youkaichao
youkaichao approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@youkaichao youkaichao enabled auto-merge (squash) November 23, 2024 06:16
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 23, 2024
@youkaichao youkaichao disabled auto-merge November 23, 2024 06:23
@youkaichao youkaichao merged commit 86a44fb into vllm-project:main Nov 23, 2024
27 of 48 checks passed
@ji-huazhong ji-huazhong deleted the platform branch November 23, 2024 07:15
@Isotr0py Isotr0py mentioned this pull request Nov 23, 2024
Merged
Isotr0py
Isotr0py reviewed Nov 23, 2024
View reviewed changes
vllm/platforms/openvino.py
Comment on lines +3 to +4
import openvino as ov
import openvino.properties.hint as hints
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed these import broke the kernel tests: https://buildkite.com/vllm/ci-aws/builds/11712#01935994-0554-41aa-bad1-9d253bdef82f/194-278

mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@ji-huazhong @mfournioux
[Platforms] Refactor openvino code (vllm-project#10573)
1955d17 
Signed-off-by: statelesshz <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@ji-huazhong
[Platforms] Refactor openvino code (vllm-project#10573)
533ab96 
Signed-off-by: statelesshz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py left review comments

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ji-huazhong @youkaichao @Isotr0py