Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Authorization ignored when root_path is set #10606

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Bug]: Authorization ignored when root_path is set #10606

merged 1 commit into from
Nov 25, 2024

Conversation

chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Nov 24, 2024 •
edited by github-actions bot
Loading

FIX: #10531

Fixed authorization ignored when root_path is set

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Nov 24, 2024
@chaunceyjiang chaunceyjiang mentioned this pull request Nov 24, 2024
Closed
1 task
@DarkLight1337
Copy link
Member

Do we have any tests for this? If not, can you add some to avoid future regressions?

@chaunceyjiang chaunceyjiang force-pushed the root_path branch 3 times, most recently from f03d51a to 635f8c5 Compare November 25, 2024 11:09
@chaunceyjiang
Copy link
Contributor Author

@DarkLight1337 PTAL.

DarkLight1337
DarkLight1337 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 25, 2024 14:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 25, 2024
@DarkLight1337 DarkLight1337 merged commit d04b13a into vllm-project:main Nov 25, 2024
61 checks passed
@chaunceyjiang chaunceyjiang deleted the root_path branch November 26, 2024 02:27
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@chaunceyjiang @afeldman-nm
[Bug]: Authorization ignored when root_path is set (vllm-project#10606)
084199b 
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@chaunceyjiang
[Bug]: Authorization ignored when root_path is set (vllm-project#10606)
1198bc2 
Signed-off-by: chaunceyjiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Authorization ignored when root_path is set
2 participants
@chaunceyjiang @DarkLight1337