Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Super tiny little typo fix #10633

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Doc] Super tiny little typo fix #10633

merged 1 commit into from
Nov 25, 2024

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Nov 25, 2024 •
edited
Loading

Hi thanks for the lib! Just a super tiny little typo fix when I play with vllm quantization to speed up inference :)

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 25, 2024
@DarkLight1337
Copy link
Member

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 25, 2024 12:21
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 25, 2024
@DarkLight1337 DarkLight1337 changed the title Super tiny little typo fix [Doc] Super tiny little typo fix Nov 25, 2024
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Nov 25, 2024

You are welcome!

@DarkLight1337 DarkLight1337 merged commit 2b0879b into vllm-project:main Nov 25, 2024
45 of 47 checks passed
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@fzyzcjy @afeldman-nm
Super tiny little typo fix (vllm-project#10633)
060ca2f 
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@fzyzcjy
Super tiny little typo fix (vllm-project#10633)
daaa340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzyzcjy @DarkLight1337