-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile.tpu pin to nightly torch_xla #11309
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Hi, @simon-mo, @khluu, would you mind add me permission for Buildkite, and I don't find link for Hi, @lsy323, @richardsliu, would you mind help to review this PR and help to enable CI for merge too? |
Signed-off-by: Manfei <[email protected]>
Signed-off-by: Manfei <[email protected]>
@WoosukKwon who is the right person to review / merge this PR? cc @bvrockwell |
I don't think we want to do this, since it will make the torch and XLA versions hard to determine. Right now we are pinning them specifically to have reliable builds. The right approach would be to add an optional path where the Dockerfile can pick up new nightly builds if specified to do so. |
Hi @ManfeiBai ! I agree with @richardsliu ... introducing instability into the requirements file like this will hurt user experience and lead to breaking vLLM CI at main (GPU users won't know why pytorch-xla is preventing them from merging their PRs, resulting in admins disabling TPU tests completely until it is fixed).
If the intention is to run regression testing on nightly dependencies so they can be fixed, is there not a better way to do this that doesn't lead to the above issues? Thanks! |
Hi, @bvrockwell, thanks for the explanation and clarification; To avoid introduce instabiliyu, I know Daniel has a solution to update this with a Flag, cc @richardsliu, let's leave this PR here or close it |
Switch vLLM docker image build with torch_xla from specific-data-10/17 to nightly
torch_xla docker image at Dec18 passed
import torch; import torch_xla