-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model][LoRA]LoRA support added for MolmoForCausalLM #11439
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
I roughly know what the reason is. I will resolve it today, and we also need to update the documentation,see :https://docs.vllm.ai/en/latest/models/supported_models.html#id3 |
This pull request has merge conflicts that must be resolved before it can be |
i might have done goofed by syncing my fork and pushing to the PR branch |
Signed-off-by: Matthias Vogler <[email protected]>
Signed-off-by: Matthias Vogler <[email protected]>
Signed-off-by: Matthias Vogler <[email protected]>
Signed-off-by: Matthias Vogler <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
@ayylemao could you plz address the branch conflict ? |
*, | ||
vllm_config: VllmConfig, | ||
prefix: str = "", | ||
lora_config: Optional[LoRAConfig] = None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can obtain lora_config
directly from vllm_config
instead of adding it as a separate argument
Thank you for your review. I will get back to it after christmas! |
[Model][LoRA]LoRA support added for MolmoForCausalLM
LoRA supported for inference in MolmoForCausalLM
Need some help with verifying this works correctly since my own tests revealed the same results for base_model and base_model+ lora.
ping @jeejeelee
FIX #11431