Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model][LoRA]LoRA support added for MolmoForCausalLM #11439

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ayylemao
Copy link

@ayylemao ayylemao commented Dec 23, 2024

[Model][LoRA]LoRA support added for MolmoForCausalLM
LoRA supported for inference in MolmoForCausalLM

Need some help with verifying this works correctly since my own tests revealed the same results for base_model and base_model+ lora.

ping @jeejeelee

FIX #11431

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Copy link
Collaborator

Need some help with verifying this works correctly since my own tests revealed the same results for base_model and base_model+ lora.

I roughly know what the reason is. I will resolve it today, and we also need to update the documentation,see :https://docs.vllm.ai/en/latest/models/supported_models.html#id3

Copy link

mergify bot commented Dec 24, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ayylemao.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@ayylemao
Copy link
Author

ayylemao commented Dec 24, 2024

i might have done goofed by syncing my fork and pushing to the PR branch
I fixed what i could, sorry for all the review requests...

Matthias Vogler added 3 commits December 24, 2024 09:54
Signed-off-by: Matthias Vogler <[email protected]>
Signed-off-by: Matthias Vogler <[email protected]>
Signed-off-by: Matthias Vogler <[email protected]>
Signed-off-by: Matthias Vogler <[email protected]>
Copy link

mergify bot commented Dec 24, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ayylemao.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 24, 2024
@jeejeelee
Copy link
Collaborator

@ayylemao could you plz address the branch conflict ?

*,
vllm_config: VllmConfig,
prefix: str = "",
lora_config: Optional[LoRAConfig] = None):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can obtain lora_config directly from vllm_config instead of adding it as a separate argument

@ayylemao
Copy link
Author

Thank you for your review.

I will get back to it after christmas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation frontend needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: AssertionError: MolmoForCausalLM does not support LoRA yet.
2 participants