Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Update disaggregation benchmark scripts and test logs #11456

Merged

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Dec 24, 2024

FIX #11455

/cc @KuntaiDu this is a minor improvement on existing benchmark tools and tests

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@KuntaiDu KuntaiDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Something that comes into my mind (you don't need to fix them in this PR):

  • Add -tp parameter to the benchmarks
  • The syntax that I use is something like "[rank0]". Would be nice if you can align the syntax.

@KuntaiDu KuntaiDu enabled auto-merge (squash) December 25, 2024 03:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 25, 2024
@KuntaiDu KuntaiDu merged commit fc60166 into vllm-project:main Dec 25, 2024
50 checks passed
@Jeffwan Jeffwan deleted the jiaxin/disaggregation-minor-test-issues branch December 25, 2024 15:35
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Dec 25, 2024

@KuntaiDu Sounds good. I will address your comments and enrich the benchmark scripts in future PRs

BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Misc]: some minor issues in disaggregation test and benchmark tools
2 participants