[Misc] Use registry-based initialization for KV cache transfer connector. #11481
Conversation
Signed-off-by: KuntaiDu <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
| ]): | ||
| raise ValueError(f"Unsupported kv_connector: {self.kv_connector}. " | ||
| f"Supported connectors are " | ||
| f"{supported_kv_connector}.") |
There was a problem hiding this comment.
Remove this part of code --- this check will be done inside the kv connector factory class.
github-actions
bot
added
the
ready
|
please also add some tests, examples, docs for it. I think you can add them after we refactor the plugin tests in #11602 |
Signed-off-by: KuntaiDu <[email protected]>
Signed-off-by: KuntaiDu <[email protected]> Signed-off-by: xcnick <[email protected]>
Get it! Let me take a look at plugin test and see how it works |
Use registry-based initialization for connector class. This allows people to add third-party connectors without writing a lot of if-else checks.