Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix signature mismatch in benchmark's get_tokenizer function #11982

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

e1ijah1
Copy link

@e1ijah1 e1ijah1 commented Jan 13, 2025

FIX #11977 (link existing issues this PR will resolve)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@e1ijah1 e1ijah1 force-pushed the bugfix/benchmark_get_tokenizer branch from b6770d9 to 16ee4b0 Compare January 13, 2025 04:13
@e1ijah1 e1ijah1 force-pushed the bugfix/benchmark_get_tokenizer branch from ae234a9 to b870182 Compare January 13, 2025 06:03
Signed-off-by: elijah <[email protected]>
Signed-off-by: elijah <[email protected]>
Signed-off-by: elijah <[email protected]>
@e1ijah1 e1ijah1 marked this pull request as ready for review January 13, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Function signature of two get_tokenizer used by benchmarks/benchmark_serving.py is not aligned
1 participant