Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend][Core][Enhacement] Add S3 and remote source support for LoRA adapters #12029

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Frontend][Core][Enhacement] Add S3 and remote source support for LoRA adapters #12029

wants to merge 1 commit into from
+1,100 −95

Conversation

Prashant18
Copy link

@Prashant18 Prashant18 commented Jan 14, 2025 •
edited by github-actions bot
Loading

Description

Add support for loading LoRA adapters from remote sources (S3, HuggingFace) with an extensible source system.

Changes

  • Add source protocol and registry for adapter sources
  • Implement S3 source with proper authentication
  • Add HuggingFace source integration
  • Update documentation with new features
  • Add comprehensive test suite

Testing

  • Unit tests for source protocol
  • Integration tests with mocked S3

Checklist

  • Code follows Google Python style guide
  • Added/updated documentation
  • Added unit tests
  • [] Added integration tests
    • Don't have a public facing bucket yet where I can add test
  • Signed DCO

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 14, 2025
@Prashant18 Prashant18 force-pushed the lora2 branch 6 times, most recently from e660ed3 to 57c5e89 Compare January 14, 2025 08:42
@Prashant18
[Frontend][Core][Enhacement] Add S3 and remote source support for LoR…
78a20f8 
…A adapters

- Expanded documentation in `lora.md` to clarify adapter path options, including local paths, Hugging Face identifiers, and S3 URIs.
- Refactored `LoRAModel` to asynchronously load adapters from remote sources, enhancing flexibility and performance.
- Introduced `resolve_adapter_path` utility to manage adapter path resolution across different sources.
- Improved error handling in `WorkerLoRAManager` for better debugging and user feedback.
- Added thread-safe S3 utilities for managing S3 interactions.

This update enhances the usability and robustness of the LoRA model management system, allowing for more versatile adapter configurations.

Signed-off-by: Prashant Patel <[email protected]>
@Prashant18 Prashant18 marked this pull request as ready for review January 14, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Prashant18