Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added specfile #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added specfile #104

wants to merge 1 commit into from

Conversation

trae32566-w
Copy link

Not sure if you guys want this. If not, that's cool, I just figured I made it for EL7 and EL8 for myself and a few others, so I might as well share it here. If you do decide to use it, it should be possible to integrate the build process for the RPM into the makefile to make it simpler to build. Currently you have to pull the source into ~/rpmbuild/SOURCES yourself, then rpmbuild -ba thinkfan.spec.

@vmatare
Copy link
Owner

vmatare commented Aug 6, 2020

Thanks, but I'm wondering... is it normal or necessary for distros to put their packaging-specific stuff upstream? Shouldn't the RPM build process have some way of downloading the source automatically? I.e. I'd expect that your specfile or whatever simply pulls the source from github. You sure it can't do that?

@vmatare
Copy link
Owner

vmatare commented Aug 6, 2020

I see you have the source URL in there, so the whole build should be able to run fully automated. I'd imagine the specfile lives somewhere in a Fedora Repo and gets built automatically in the cloud. Why would you want to put it in the upstream repo?

@trae32566-w
Copy link
Author

trae32566-w commented Aug 10, 2020

I mean it really seems to depend on the project; personally, I prefer having it and all necessary packaging configurations in my repo. I guess my thinking was just that it's specific to Thinkfan more than specific to one distro (RPM is used for several OSs), so it might've been useful to have in the Thinkfan repo. The only RPM-based repository any version of Thinkfan lives in right now is Fedora, not RHEL or CentOS (EPEL would be a good candidate for this though), so if anyone wants to build it, they've gotta go grab the specfile from somewhere and use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants