-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added img basename explainer #1
Open
vmpstr
wants to merge
1
commit into
main
Choose a base branch
from
img-basename-explainer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,22 @@ | ||
# web-proposals | ||
# Web Proposals | ||
|
||
This is a grab-bag of various web proposals, both HTML and CSS. | ||
|
||
## IMG `basename` attribute | ||
|
||
The IMG `basename` attribute is an attribute specified on the IMG element, | ||
which allows the developer to assist the User Agent in specifying the name of | ||
this image. This is used when the User Agent allows the user to download the | ||
image, either via "Save Image" dialog option or drag-and-dropping it into a | ||
directory on the machine. | ||
|
||
[initial proposal](https://github.com/whatwg/html/issues/2722) | ||
[explainer](https://github.com/vmpstr/web-proposals/blob/main/explainers/img-basename.md) | ||
|
||
## Display Locking | ||
|
||
[dedicated repo](https://github.com/WICG/display-locking) | ||
|
||
## Shared Element Transitions | ||
|
||
[dedicated repo](https://github.com/WICG/shared-element-transitions) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# IMG `basename` | ||
|
||
## Summary | ||
|
||
The IMG `basename` attribute is an attribute specified on the IMG element. It | ||
indicates the basename of the filename to use when the user saves the image, | ||
either via "Save Image" dialog option or by drag-and-dropping the image to the | ||
system directory. | ||
|
||
## Details | ||
|
||
* [Initial proposal and discussion]([initial proposal](https://github.com/whatwg/html/issues/2722) | ||
|
||
It is common for images to be served from servers that obfuscate filenames to | ||
optimize storage. In this case, the User Agent uses the obfuscated filename as | ||
the suggested filename to use when saving the file. | ||
|
||
It is also possible that images come from a `data:` url, meaning that they | ||
don't have a filename associated with them. In this case, the User Agent | ||
selects a filename arbitrarily, with `download` and `unknown` being common | ||
choices. | ||
|
||
In either case, a better user experience would be to have developers specify | ||
the basename to use, since developers have contextual information for the type | ||
of image being downloaded. This is the proposal for the `basename` attribute. | ||
|
||
Note that since the extension of the filename can be determined automatically | ||
by the User Agent, we feel that the choice should not be in the developer's | ||
options to avoid security problems (e.g. developer picking `.exe` as an | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As well as the security issue, the image may be one of multiple formats depending on client side configuration ( |
||
extension for the image which can cause inadvertent code execution by the | ||
user). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts about making this work on
<canvas>
,<video>
and<audio>
too?