This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Add a couple more grains - vpc and nvme #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are in the process of migrating from EC2 Classic to VPC. We've found a couple of small things have really helped us: 1. Adding an is_vpc grain, so that we can easily tell whether this instance is or is not in a VPC 2. Adding an `is_nvme_disk` grain so we can identify Nitro based instances which use /dev/nvme.. instead of /dev/x...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in the process of migrating from EC2 Classic to VPC. We've found a couple of small things have really helped us:
is_nvme_diskgrain so we can identify Nitro based instances which use /dev/nvme.. instead of /dev/x...We're not massively wedded to the style I've built these grains in, and so if there are strong opinions on how this should be laid out, then we can happily modify them :)
We found the VPC one is available if you can get the metadata for the mac and then use that to parse the vpc, but adding
is_vpcwas so much easier :)