Advanced workflow for complete e2e test #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khannakshat7
changed the title
|
Just as a reminder: after closing this issue, also close the WIP PR #452. |
|
@khannakshat7 Can we add this info to CONTRIBUTING.md ? |
anusha94
approved these changes
Jun 9, 2022
Closed
Merged
shivi28
reviewed
Jun 29, 2022
|
Hi @khannakshat7, thanks for the changes. If you are still interested, then can you please convert this to PR? |
|
Hi @shivi28, I have converted this to PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This workflow is needed when we want to run full e2e tests for the PR before merging.
Additional information
We have to add label
pr/run-all-e2e-testto run all the e2e tests on the PR.Special notes for your reviewer
I tried many different implementations-
/test-full-e2eto run e2e test but it failed as the event was triggered but was not updating in checks in the PR./test-full-e2eto create a workflow to add label to PR by Github bot and then running the e2e tests but it failed becoz a GitHub workflow cannot trigger another workflow.