Bump referenced Velero tag. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
bump_velero_tag
branch
from
e1538ae
to
c7e9fb1
Compare
ywk253100
approved these changes
Jul 28, 2023
shubham-pampattiwar
approved these changes
Jul 28, 2023
kaovilai
reviewed
Jul 28, 2023
| k8s.io/api v0.22.2 | ||
| k8s.io/apimachinery v0.22.2 | ||
| github.com/stretchr/testify v1.8.2 | ||
| github.com/vmware-tanzu/velero v0.0.0-20230727074327-a6d79fc272a2 |
There was a problem hiding this comment.
why not a specific tagged release? like v1.11.1?
There was a problem hiding this comment.
would be easier to read and match with tagged commits in the future.
There was a problem hiding this comment.
@kaovilai this is for the main branch, not release-1.11 -- ongoing dev work for a release that will come out with 1.12. Not sure about this plugin, but certainly the CSI pluign needs post-1.11 stuff. On the release branch, we can peg this to a specific release tag, but for ongoing dev work, that's not always possible. This is just the lastest main commit as of when this PR was submitted.
kaovilai
approved these changes
Jul 29, 2023
|
I imagine this is something CI (github actions) could do on a regular basis to check for breakage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.