-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ingressclass from ingress #7813
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: AlbeeSo <[email protected]>
Signed-off-by: AlbeeSo <[email protected]>
Signed-off-by: AlbeeSo <[email protected]>
Signed-off-by: AlbeeSo <[email protected]>
ced78cc
to
7bb8c22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7813 +/- ##
==========================================
- Coverage 58.67% 58.65% -0.02%
==========================================
Files 345 347 +2
Lines 28743 28797 +54
==========================================
+ Hits 16866 16892 +26
- Misses 10448 10473 +25
- Partials 1429 1432 +3 ☔ View full report in Codecov by Sentry. |
IMHO, this should remain an "optional" plugin, b/c there may be other cases, where the same ingress will use a different ingressclass, or the same ingressclass like "default" may have different settings across different clusters. |
'default' may be different, but if 'default' already exists it will skip to restore by default, right? |
Signed-off-by: AlbeeSo <[email protected]>
28b63d1
to
a72ec6a
Compare
@AlbeeSo As for StorageClass in particular, those are generally configured by the cluster admin. Simply creating a StorageClass kubernetes resource without configuring the storage behind the storageclass wouldn't be helpful. If you are restoring a backup to a cluster where the storageclass for your PVCs doesn't exist, then you'd either need to first get the admin to create and configure that storageclass, or if there's another appropriate storageclass available, then you can use the storageclass mapping feature on restore to use storage already available. |
Got it. So will action like "velero.io/change-ingress-class" be more suitable for this case, or restoring ingress class directly is enough? @reasonerjt @sseago |
IMHO, restoring the ingressclass is enough, and I can add the "velero.io/change-ingress-class" to allow users to change it if need. |
"velero.io/change-ingress-class" will not be needed as velero now supports resource modifier to modify restored resources in a more general way: |
Thank you for contributing to Velero!
Please add a summary of your change
To backup / restore ingressclass if ingress is backuped and spec.ingressClass is not nil.
After PR, ingressclass will be backuped with logs like
And will be restored with logs like
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.