Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data mover restore for Windows #8594

Merged

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Jan 9, 2025

For issue #8418. Data mover restore for Windows

@Lyndon-Li Lyndon-Li force-pushed the data-mover-restore-for-windows branch from 0c1d1d5 to e9cd583 Compare January 9, 2025 06:16
@Lyndon-Li Lyndon-Li force-pushed the data-mover-restore-for-windows branch 4 times, most recently from 9651df2 to f0ea0b3 Compare January 9, 2025 07:08
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 61.85567% with 37 lines in your changes missing coverage. Please review.

Project coverage is 59.20%. Comparing base (be5f56a) to head (a846912).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/cli/datamover/restore.go 0.00% 12 Missing ⚠️
pkg/exposer/generic_restore.go 68.57% 9 Missing and 2 partials ⚠️
pkg/controller/data_download_controller.go 71.42% 8 Missing and 2 partials ⚠️
pkg/exposer/csi_snapshot.go 40.00% 2 Missing and 1 partial ⚠️
pkg/controller/data_upload_controller.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8594      +/-   ##
==========================================
+ Coverage   59.18%   59.20%   +0.02%     
==========================================
  Files         370      370              
  Lines       39622    39718      +96     
==========================================
+ Hits        23449    23516      +67     
- Misses      14689    14715      +26     
- Partials     1484     1487       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the data-mover-restore-for-windows branch 8 times, most recently from 0718720 to ad4126d Compare January 9, 2025 09:27
@Lyndon-Li Lyndon-Li marked this pull request as ready for review January 10, 2025 02:48
@Lyndon-Li Lyndon-Li requested a review from blackpiglet January 10, 2025 02:49
ywk253100
ywk253100 previously approved these changes Jan 10, 2025
@Lyndon-Li Lyndon-Li force-pushed the data-mover-restore-for-windows branch from 3667d01 to a846912 Compare January 10, 2025 08:58
@Lyndon-Li Lyndon-Li requested a review from kaovilai January 10, 2025 09:23
@Lyndon-Li Lyndon-Li merged commit 3207619 into vmware-tanzu:main Jan 13, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants