Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swallowed errors in session package #1763

Open
wants to merge 1 commit into
base: eng
Choose a base branch
from
Open

Fix swallowed errors in session package #1763

wants to merge 1 commit into from

Conversation

aaronjwood
Copy link
Member

All of this stuff was picked up by the linter we use (https://github.com/golangci/golangci-lint)

manojkumarjain
manojkumarjain approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@manojkumarjain manojkumarjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aaronjwood
Copy link
Member Author

Just wanted to follow up. Is there still an interest in merging this?

@aaronjwood
Copy link
Member Author

Hi, any update on this?

@mayank-avinetworks
Copy link
Contributor

Hi, any update on this?

Hello Aron,
Nothing a the moment, very occupied with critical tasks. we will try to review it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojkumarjain manojkumarjain manojkumarjain approved these changes

@mayank-avinetworks mayank-avinetworks Awaiting requested review from mayank-avinetworks

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronjwood @mayank-avinetworks @manojkumarjain @vmwclabot