[area/documentation] (#162) Minimal infrastructure setup update #384

ivan-zdravkov · 2024-08-09T14:05:37Z

Description

The minimal infrastructure documentation now guides us through setting up all the application docker containers that host the infrastructure, the connectivity and application access, the dev environment, creating a project from archetypes, running and testing the project locally, setting up the GitLab CI/CD pipeline, and finally building, deploying and pushing artifacts.

Shell file removed as it is no longer needed.

docker-compose updated to work with nginx, nexus, gitlab, and a custom gitlab-runner.

.m2/settings.xml added to the infrastructure folder.

gitlab-runner Dockerfile added with openjdk, maven and nodejs on top.

nginx configuration changed.

Checklist

I have added relevant error handling and logging messages to help troubleshooting
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation, relevant usage information (if applicable)
I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
I have added labels for implementation kind (kind/) and version type (version/)
I have tested against live environment, if applicable
I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Full testing can be done by following the changed Readme.md as that is the intention of the changes.

Release Notes

The minimal infrastructure guide updated and simplified to better lead adoption.

Related issues and PRs

#162

VenelinBakalov · 2024-08-12T08:24:37Z

infrastructure/.m2/settings.xml

+                <repository>
+                    <id>releases</id>
+                    <name>pscoe</name>
+                    <url>http://infra.corp.local/nexus/repository/maven-releases/</url>
+                    <releases>
+                        <enabled>true</enabled>
+                    </releases>
+                    <snapshots>
+                        <enabled>false</enabled>
+                    </snapshots>
+                </repository>


@ivan-zdravkov @ivo-kotev @Michaelpalacce those https alerts should be safe to dismiss in this specific case right? this is adding the basic configuration to get things running and it can later be updated easily based on customer preference

@VenelinBakalov, yes exactly. We are overriding this security requirement in the settings.xml itself (Maven requires https) as well since this is strictly internal traffic. Maybe we should make a note of that in the documentation.

I'm 50/50 on the matter. We should be able to serve HTTPS with self-signed certificates. But either work for me. The error itself is whatever in this case, but at the same time https > http even for this

infrastructure/.m2/settings.xml

VenelinBakalov · 2024-08-12T10:31:55Z

infrastructure/etc/hosts

@@ -1,6 +0,0 @@
-# vRA IaaC START SECTION


I see we are removing this file, are things working without it? is it the "extra_hosts" property the one that replaces hosts configuration (just note, i am asking because I don't have a lot of knowledge in this area and not as a change request for the pr)

Yeah, we don't need this. I initially tried getting it to work, but never could. It appeared to be obsolete even initially, since we are not using the thus defined hosts, but instead the base infra.corp.local. Docker compose configures internal image-to-image hosts and addresses and on the host machine we only need the infra.corp.local 127.0.0.0 binding.

I see thanks.

VenelinBakalov · 2024-08-12T11:23:18Z

infrastructure/readme.md

-* 172.18.0.11 - gitlab.corp.local (GitLab CE)
-* 172.18.0.12 - gitlab-runner.corp.local (GitLab CI Runner)
-* 172.18.0.13 - artifactory.corp.local (JFrog Artifactory)
+Using these applications, the infrastructure will support source control, running the build pipeline as well as hosting and serving the artifact packages, which are all the minimal requirements to have an [Aria Build Tools](../README.md) project.


Suggested change

Using these applications, the infrastructure will support source control, running the build pipeline as well as hosting and serving the artifact packages, which are all the minimal requirements to have an [Aria Build Tools](../README.md) project.

Using these applications, the infrastructure will support source control, running the build pipeline as well as hosting and serving the artifact packages, which are all the minimal requirements to have an [Build Tools for VMware Aria](../README.md) project.

VenelinBakalov · 2024-08-12T12:55:29Z

infrastructure/readme.md

+
+2. Navigate to the `infrastructure` folder:
+    ```
+    cd infrastructure


Suggested change

cd infrastructure

cd build-tools-for-vmware-aria/infrastructure

VenelinBakalov · 2024-08-14T12:16:01Z

infrastructure/docker-compose.yml

    ports:
-    - "127.0.0.1:8080:80"
+      - 8082:80 # Web Interface


Interesting but for the gitlab-ce i got an error: "ERROR: for gitlab Cannot create container for service gitlab: invalid port specification: "481342"
In order to fix it, I had to use quotes. I am not sure why it happened only for this container..
ports:
- "8082:80" # Web Interface
- "8022:22" # SSH

ivan-zdravkov · 2024-08-26T06:39:38Z

I will be updating the guide for Linux and update the Installation section to drop the Docker Desktop dependencies

vmwclabot · 2024-09-13T10:37:04Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 3451d96 must be signed by [email protected]

vmwclabot · 2024-09-13T10:37:04Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 3451d96 must be signed by [email protected]

vmwclabot · 2024-09-13T11:14:19Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 44af649 must be signed by [email protected]

vmwclabot · 2024-09-13T11:14:19Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 44af649 must be signed by [email protected]

The minimal infrastructure documentation now guides us through setting up all the application docker containers that host the infrastructure, the connectivity and application access, the dev environment, creating a project from archetypes, running and testing the project locally, setting up the GitLab CI/CD pipeline, and finally building, deploying and pushing artifacts. Shell file removed as it is no longer needed. docker-compose updated to work with nginx, nexus, gitlab, and a custom gitlab-runner. .m2/settings.xml added to the infrastructure folder. gitlab-runner Dockerfile added with openjdk, maven and nodejs on top. nginx configuration changed. Fixed #162 Signed-off-by: Ivan Zdravkov <[email protected]>

vmwclabot · 2024-09-19T04:14:29Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]

vmwclabot · 2024-09-19T04:14:29Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]

VenelinBakalov · 2024-09-19T18:02:49Z

infrastructure/readme.md

+        - echo "GROUP_ID=$(mvn help:evaluate -Dexpression=project.groupId -q -DforceStdout)" >> build.env
+        - echo "ARTIFACT_ID=$(mvn help:evaluate -Dexpression=project.artifactId -q -DforceStdout)" >> build.env
+        - echo "PROJECT_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)" >> build.env
+      artifacts:


For some reason the artifacts part fails to execute

WARNING: Uploading artifacts as "dotenv" to coordinator... POST http://infra.corp.local/gitlab/api/v4/jobs/1/artifacts: 400 Bad Request (Invalid Format) id=1 responseStatus=400 Bad Request status=400 token=glcbt-64 FATAL: invalid argument ERROR: Job failed: exit status 1

Commenting this out makes the build successful

VenelinBakalov · 2024-09-19T18:03:43Z

infrastructure/readme.md

+    test:
+      stage: test
+      script:
+        - mvn test


Suggested change

- mvn test

- mvn -Dmaven.repo.local=$CI_PROJECT_DIR/.m2/repository test

VenelinBakalov · 2024-09-19T19:16:14Z

infrastructure/.m2/settings.xml

+            <repositories>
+                <repository>
+                    <id>releases</id>
+                    <name>pscoe</name>


Suggested change

<name>pscoe</name>

<name>maven-releases</name>

I am not sure if the name here needs to match the name in nexus but if it does, we can update it

VenelinBakalov · 2024-09-19T19:16:31Z

infrastructure/.m2/settings.xml

+                </repository>
+                <repository>
+                    <id>snapshots</id>
+                    <name>pscoe</name>


Suggested change

<name>pscoe</name>

<name>maven-snapshots</name>

Signed-off-by: Ivan Zdravkov <[email protected]>

vmwclabot · 2024-09-20T08:14:21Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]

vmwclabot · 2024-09-20T08:14:21Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]

vmwclabot · 2024-09-20T08:50:42Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]

vmwclabot · 2024-09-20T08:50:42Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]

Signed-off-by: Ivan Zdravkov <[email protected]>

vmwclabot · 2024-09-20T09:15:43Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]

vmwclabot · 2024-09-20T09:15:44Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]

Signed-off-by: Ivan Zdravkov <[email protected]>

vmwclabot · 2024-09-20T09:36:56Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]

vmwclabot · 2024-09-20T09:36:56Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]

vmwclabot · 2024-09-20T12:11:45Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]
Commit cad6e00 must be signed by [email protected]

vmwclabot · 2024-09-20T12:11:46Z

@ivan-zdravkov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit cf42598 must be signed by [email protected]
Commit 6f79519 must be signed by [email protected]
Commit cad6e00 must be signed by [email protected]

VenelinBakalov · 2024-09-25T10:31:51Z

infrastructure/.m2/settings.xml

+    <profiles>
+        <profile>
+            <id>nexus</id>
+            <repositories>


Suggested change

<repositories>

<properties>

<releaseRepositoryUrl>

http://infra.corp.local/nexus/repository/maven-releases/</releaseRepositoryUrl>

<snapshotRepositoryUrl>

http://infra.corp.local/nexus/repository/maven-snapshots/</snapshotRepositoryUrl>

</properties>

<repositories>

VenelinBakalov · 2024-09-26T11:37:02Z

infrastructure/.m2/settings.xml

+<settings xmlns="http://maven.apache.org/SETTINGS/1.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.1.0 http://maven.apache.org/xsd/settings-1.1.0.xsd">
+    <servers>
+        <server>
+            <id>nexus</id>


Suggested change

<id>nexus</id>

<id>releases</id>

And we need to add 1 more similar server with id snapshots

<server> <id>snapshots</id> <username>admin</username> <password>VMware1!</password> </server>

ivan-zdravkov added the area/documentation Relates to improvements or additions to documentation label Aug 9, 2024

ivan-zdravkov assigned Michaelpalacce and ivan-zdravkov Aug 9, 2024

ivan-zdravkov linked an issue Aug 9, 2024 that may be closed by this pull request

Create a minimal infrastructure template #162

Open

github-advanced-security bot found potential problems Aug 9, 2024

View reviewed changes

VenelinBakalov reviewed Aug 12, 2024

View reviewed changes

VenelinBakalov reviewed Aug 14, 2024

View reviewed changes

VenelinBakalov added version/minor Introduces a non-breaking feature or change kind/feature New Feature to the project labels Aug 16, 2024

VenelinBakalov changed the title ~~[area/documentation] Minimal infrastructure documentation updated.~~ [area/documentation] Minimal infrastructure setup update Aug 16, 2024

VenelinBakalov changed the title ~~[area/documentation] Minimal infrastructure setup update~~ [area/documentation] (#162) Minimal infrastructure setup update Aug 16, 2024

VenelinBakalov added the area/build Relates to the build process label Aug 16, 2024

vmwclabot added dco-required labels Sep 13, 2024

ivan-zdravkov force-pushed the minimal-infrastructure branch from 3451d96 to 44af649 Compare September 13, 2024 11:14

Ivan Zdravkov and others added 2 commits September 19, 2024 07:14

Containers up and running for Linux

cf42598

ivan-zdravkov force-pushed the minimal-infrastructure branch from 44af649 to cf42598 Compare September 19, 2024 04:14

VenelinBakalov reviewed Sep 19, 2024

View reviewed changes

Landing page simplified and build tools build section dropped

44a17fa

Signed-off-by: Ivan Zdravkov <[email protected]>

Small additions to the infrastructure readme

6f79519

Improve the Infrastructure readme semantics

ed7bdb2

Signed-off-by: Ivan Zdravkov <[email protected]>

Fix list identation

ef0231d

Signed-off-by: Ivan Zdravkov <[email protected]>

nvm linked

cad6e00

VenelinBakalov reviewed Sep 25, 2024

View reviewed changes

VenelinBakalov reviewed Sep 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[area/documentation] (#162) Minimal infrastructure setup update #384

[area/documentation] (#162) Minimal infrastructure setup update #384

ivan-zdravkov commented Aug 9, 2024

VenelinBakalov Aug 12, 2024

ivan-zdravkov Aug 12, 2024 •

edited

Loading

Michaelpalacce Aug 12, 2024

VenelinBakalov Aug 12, 2024

ivan-zdravkov Aug 12, 2024

VenelinBakalov Aug 13, 2024

VenelinBakalov Aug 12, 2024

VenelinBakalov Aug 12, 2024

VenelinBakalov Aug 14, 2024

ivan-zdravkov commented Aug 26, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 19, 2024

vmwclabot commented Sep 19, 2024

VenelinBakalov Sep 19, 2024

VenelinBakalov Sep 19, 2024

VenelinBakalov Sep 19, 2024

VenelinBakalov Sep 19, 2024

VenelinBakalov Sep 19, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

VenelinBakalov Sep 25, 2024

VenelinBakalov Sep 26, 2024

	Using these applications, the infrastructure will support source control, running the build pipeline as well as hosting and serving the artifact packages, which are all the minimal requirements to have an [Aria Build Tools](../README.md) project.
	Using these applications, the infrastructure will support source control, running the build pipeline as well as hosting and serving the artifact packages, which are all the minimal requirements to have an [Build Tools for VMware Aria](../README.md) project.

	cd infrastructure
	cd build-tools-for-vmware-aria/infrastructure

	- mvn test
	- mvn -Dmaven.repo.local=$CI_PROJECT_DIR/.m2/repository test

-            <repositories>
+            <properties>
+                 <releaseRepositoryUrl>
+          http://infra.corp.local/nexus/repository/maven-releases/</releaseRepositoryUrl>
+                  <snapshotRepositoryUrl>
+          http://infra.corp.local/nexus/repository/maven-snapshots/</snapshotRepositoryUrl>
+            </properties>
+            <repositories>

[area/documentation] (#162) Minimal infrastructure setup update #384

Are you sure you want to change the base?

[area/documentation] (#162) Minimal infrastructure setup update #384

Conversation

ivan-zdravkov commented Aug 9, 2024

Description

Checklist

Testing

Release Notes

Related issues and PRs

Choose a reason for hiding this comment

ivan-zdravkov Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivan-zdravkov commented Aug 26, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 13, 2024

vmwclabot commented Sep 19, 2024

vmwclabot commented Sep 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

vmwclabot commented Sep 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivan-zdravkov Aug 12, 2024 •

edited

Loading