Add tm Org and VDC support #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
approved these changes
Oct 2, 2024
| return &s | ||
| } | ||
|
|
||
| func (vcdClient *VCDClient) GetAllSupervisors(queryParameters url.Values) ([]*Supervisor, error) { |
There was a problem hiding this comment.
Should we add docs to public methods?
lvirbalas
reviewed
Oct 3, 2024
| `VCDClient.GetTmVdcById`, `TmVdc.Update`, `TmVdc.Delete`, `.TmVdc.Disable` [GH-710] | ||
| * Added types `Region` and `types.Region` for managing regions with methods | ||
| `VCDClient.CreateRegion`, `VCDClient.GetAllRegions`, `VCDClient.GetRegionByName`, | ||
| `VCDClient.GetRegionById`, `Region.Update`, `Region.Delete` [GH-710] |
There was a problem hiding this comment.
I'm a bit hesitant to merge this PR until we can write tests for create/update/delete.
adambarreiro
reviewed
Oct 3, 2024
|
|
||
| func (vcdClient *VCDClient) CreateTmOrg(config *types.TmOrg) (*TmOrg, error) { | ||
| if !vcdClient.Client.IsTm() { | ||
| return nil, fmt.Errorf("err") |
There was a problem hiding this comment.
Just noticed this error message, looks incomplete?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog contains more details on the implemented structures.
make testtmpasses.