Validate rule sequence numbers on create only #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
wsquan171
approved these changes
Oct 18, 2023
Comment on lines
91
to
93
| err := validatePolicyRuleSequence(d) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
nit: for simplicity
if err := validatePolicyRuleSequence(d); err != nil {
return err
}
Since sequence number is Computed in rule, bad sequence numbers may be stuck in state as a result of configurations with previous provider version. Rather than throwing an error, the provider will auto-correct the sequence number while also logging this event. For create flow, we leave sequence number validation since state for new object is clean. Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
fix-sequence-number-validation
branch
from
8de90fa to
eab9f72
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sequence number is Computed in rule, bad sequence numbers may be stuck in state as a result of configurations with previous provider version.
Rather than throwing an error, the provider will auto-correct the sequence number while also logging this event.
For create flow, we leave sequence number validation since state for new object is clean.