Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe NSX API endpoint in manager cluster #1003

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Probe NSX API endpoint in manager cluster #1003

merged 2 commits into from
Oct 24, 2023

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Oct 18, 2023

In manager cluster resource, probe for NSX connectivity before joining cluster nodes. Parameters for connection probing are specified within node_connectivity block.

This option is useful since nsx manager nodes might be spawned within same apply process, in which case it would take a while for NSX API endpoint to become responsive. Rather than using custom provisioner script to ensure connectivity, we give a probe and wait option in manager cluster resource.

Standard retry mechanism will not be present in this connection probing in order to avoid duplication (we expect retry parameters to be very different for regular retry and initial connection probing)

In manager cluster resource, probe for NSX connectivity before
joining cluster nodes. Parameters for connection probing are
specified within `node_connectivity` block.

This option is useful since nsx manager nodes might be spawned
within same apply process, in which case it would take a while
for NSX API endpoint to become responsive. Rather than using
custom provisioner script to ensure connectivity, we give a
probe and wait option in manager cluster resource.

Standard retry mechanism will not be present in this connection
probing in order to avoid duplication (we expect retry parameters
to be very different for regular retry and initial connection probing)

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm annakhm requested a review from salv-orlando October 23, 2023 19:26
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Oct 24, 2023
@annakhm
Copy link
Collaborator Author

annakhm commented Oct 24, 2023

/test-all

@annakhm
Copy link
Collaborator Author

annakhm commented Oct 24, 2023

/test-all

@annakhm annakhm merged commit 7439289 into master Oct 24, 2023
2 checks passed
@annakhm annakhm deleted the wait-conn2 branch February 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-required DCO Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants