Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter error #1016

Merged
merged 1 commit into from
Oct 27, 2023
+2 −12
Merged

Fix linter error #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 3.4.0 (October 26, 2023)
## 3.4.0 (October 27, 2023)

FEATURES:
* Multitenancy support. Supported resources and data sources can now be created within a context of a project. In order to specify a project, use `context` block within resource or data source, and specify `project_id` within. For the full list of supported resources, please refer to [Multitenancy Guide](https://registry.terraform.io/providers/vmware/nsxt/latest/docs/guides/multitenancy).
Expand All @@ -9,7 +9,7 @@ As part of multitenancy support, project resource and data source are offered, a
* `resource/nsxt_policy_project`

BUG FIXES:
* `resource/nsxt_policy_security_policy`, `resource/nsxt_policy_gateway_policy`: Validate correctness of sequence numbers only on policy creation, and skip this check on update, but rather auto-correct sequence numbers if needed. This is in order to avoid erroring out in case of incorrect sequence numbers that got assigned in previous provider version ([#1001](https://github.com/vmware/terraform-provider-nsxt/pull/1001))
* `resource/nsxt_policy_security_policy`, `resource/nsxt_policy_gateway_policy`: Validate correctness of sequence numbers only on policy creation, and skip this check on update, but rather auto-correct sequence numbers if needed. This is in order to avoid erroring out in case of incorrect sequence numbers that got assigned with previous provider version ([#1001](https://github.com/vmware/terraform-provider-nsxt/pull/1001))
* Escape all special characters in data sources, as required by search API. This fixes and issue with search by `display_name` that was not working as expected in case it contained some special characters ([#993](https://github.com/vmware/terraform-provider-nsxt/pull/993))

EXPERIMENTAL FEATURES:
Expand Down
10 changes: 0 additions & 10 deletions nsxt/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,16 +886,6 @@ func applyLicense(connector client.Connector, licenseKey string) error {
return nil
}

func removeLicense(connector client.Connector, licenseKey string) error {
client := nsx.NewLicensesClient(connector)
err := client.Delete(licenseKey)
if err != nil {
return fmt.Errorf("error during license delete: %v", err)
}

return nil
}

// license keys are applied on terraform plan and are not removed
func configureLicenses(connector client.Connector, intentLicenses []string) error {
if len(intentLicenses) == 0 {
Expand Down