chore: update golangci-lint configuration

[tenthirtyam]

Summary of Pull Request

Updates golangci-lint configuration.

Type of Pull Request

• This is a bug fix.
• This is an enhancement or feature.
• This is a code style/formatting update.
• This is a documentation update.
• This is a refactoring update.
• This is a chore update
• This is something else.
  Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

• Tests have been completed.
• Documentation has been added/updated.

BEFORE:

➜ golangci-lint run
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 

AFTER:

➜ golangci-lint run
nsxt/resource_nsxt_policy_project_test.go:572:6: func `testAccNsxtPolicyProjectTemplateWithIPBlock` is unused (unused)
func testAccNsxtPolicyProjectTemplateWithIPBlock(displayName string) string {
     ^

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

[tenthirtyam]

@vmware/terraform-provider-nsxt-maintainers: reminder.

[salv-orlando]

@tenthirtyam I apologise if this is a dumb question, but looking at the "after" behaviour, will this change start reporting linter errors for rules we have excluded such as G115 and G402?

[tenthirtyam]

Likely. I can update these new format to account for this for you.

[tenthirtyam]

@salv-orlando - I've updated the config again in 6b7935e and have verified that those existing exlusions for gosec and staticcheck will continue to be excluded.

➜ golangci-lint run
nsxt/resource_nsxt_policy_project_test.go:572:6: func `testAccNsxtPolicyProjectTemplateWithIPBlock` is unused (unused)
func testAccNsxtPolicyProjectTemplateWithIPBlock(displayName string) string {
     ^

And the above is addressed in #1499 by @ksamoray