Ignore create_service_account with NSX 9.0.0 #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
In compute manager resource, NSX no longer accepts false value for create_service_account attribute. Since terraform sdk can't distinguish between unset value and false value for the attribute, we will ignore the attribute entirely for NSX 9.0 and above Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
service-account-refix
branch
from
b57ff81 to
a04e6b4
Compare
ksamoray
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In compute manager resource, NSX no longer accepts false value for create_service_account attribute.
Since terraform sdk can't distinguish between unset value and false value for the attribute, we will ignore the attribute entirely for NSX 9.0 and above