Implement map data sources for policy services and groups #1476
+390
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
list_data_sources
branch
from
818a5f5 to
191c280
Compare
|
/test-all |
annakhm
reviewed
Dec 5, 2024
| return err | ||
| } | ||
| for _, r := range results.Results { | ||
| groupMap := make(map[string]interface{}) |
There was a problem hiding this comment.
do we want to error out for duplicate display_name?
ksamoray
force-pushed
the
list_data_sources
branch
2 times, most recently
from
873c26d to
7c7fde9
Compare
annakhm
changed the title
annakhm
changed the title
ksamoray
force-pushed
the
list_data_sources
branch
from
7c7fde9 to
4a18c0a
Compare
These data sources allows the retrieval of the entire tables from NSX to save multiple calls to the backend. Fixes: vmware#696 Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
list_data_sources
branch
from
4a18c0a to
cc7c11d
Compare
ksamoray
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These data sources allows the retrieval of the entire tables from NSX to save multiple calls to the backend.
Fixes: #696